fix cli annotation flagSet to StringArrayVar #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2702 +/- ##
==========================================
+ Coverage 69.2% 69.21% +<.01%
==========================================
Files 278 278
Lines 17449 17449
==========================================
+ Hits 12076 12077 +1
+ Misses 4045 4040 -5
- Partials 1328 1332 +4
|
wangforthinker
force-pushed
the
fix/cli-annotation-flagSet
branch
from
56694f2
to
0fd86a6
Compare
Signed-off-by: allen.wang <allen.wq@alipay.com>
wangforthinker
force-pushed
the
fix/cli-annotation-flagSet
branch
from
0fd86a6
to
17b32e6
Compare
|
ping @fuweid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
flagset.StringSlice will split args by comma so that the annotation parse job fails. Should use StringArray for env/labels.
Ⅱ. Does this pull request fix one issue?
NONE.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
add test.
Ⅳ. Describe how to verify it
add test.
Ⅴ. Special notes for reviews
related to #2171.